fix(id): avoid comparing partial fixtures before head (#4820) - #5360

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

🤖 Agent note · picked up

• Agent: queue worker (repo-worker-code), lane W shift
• Session / ID: task 9341
• Found via: queue claim
• Task: triage review-gate for PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 — its production-line-guard check (run 41799038498) failed; determining whether the failure belongs to PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 or is inherited from main
• Expectation: xs — disposition posted on PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 this shift; no code change expected on PR fix(id): avoid comparing partial fixtures before head (#4820) #5360
• Links: PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 (for issue id(world_fixture): a partial fixture ending mid-epoch is record-compared anyway — final_epoch_covered checks only that an install exists, not that the window reaches the header sequence #4820); guard failure on main tracked by issue main CI failure: production-line-guard (run 41790193563) #5358, fix in PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 (task 9340)

🤖 Agent note · done

• Agent: queue worker (repo-worker-code), lane W shift
• Session / ID: task 9341
• Found via: queue claim (review-gate triage, source run 41799038498)
• Task: triage complete — the production-line-guard failure on PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 is inherited from main, not caused by PR fix(id): avoid comparing partial fixtures before head (#4820) #5360
• Evidence:
  • PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 diff is a single file: pkgs/id/src/world_fixture.rs (+38/−14, commit 6da540e) for issue id(world_fixture): a partial fixture ending mid-epoch is record-compared anyway — final_epoch_covered checks only that an install exists, not that the window reaches the header sequence #4820. It touches no production file near the line limit.
  • The guard failure on main is tracked by issue main CI failure: production-line-guard (run 41790193563) #5358: pkgs/id/src/world/core.rs is 2515 production lines on main, over the 2500 limit (main run 41790193563). PR fix(id): avoid comparing partial fixtures before head (#4820) #5360's branch sits on that same main, so the guard fails on this PR for a file it does not touch.
  • The fix is already owned: PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 (task 9340) extracts checkpoint parts from world/core.rs; PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 is OPEN and its own guard check is pending (run 41802717827) as of this note.
• Expectation: no change is needed on PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 for this gate. Once PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 merges, re-run CI on PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 (or rebase it) and the guard should pass, assuming no new over-limit file appears. PR fix(id): avoid comparing partial fixtures before head (#4820) #5360's own targeted-test evidence is in its body (world_fixture, 28 passed, per its author).
• Links: PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 · issue id(world_fixture): a partial fixture ending mid-epoch is record-compared anyway — final_epoch_covered checks only that an install exists, not that the window reaches the header sequence #4820 · issue main CI failure: production-line-guard (run 41790193563) #5358 · PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 · task 9340

🤖 Agent note · parked

• Agent: queue worker (repo-worker-code), lane W shift
• Session / ID: task 9341
• Found via: queue claim
• Task: follow-up to the triage disposition above — the triage itself is done; only the queue bookkeeping is outstanding
• Expectation: the queue backend (PostgREST) was down for the whole shift after the claim (503 PGRST002, curl timeouts, then 521/525), so the lane/checkpoint/complete verbs for task 9341 could not be confirmed despite repeated attempts. The claim lease expires and task 9341 returns to the queue: the next claimant should complete task 9341 as triaged from the disposition note above without redoing the triage. Claim labels are being removed from PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 so its label state does not claim work nobody holds.
• Links: PR fix(id): avoid comparing partial fixtures before head (#4820) #5360 · issue main CI failure: production-line-guard (run 41790193563) #5358 · PR fix(id): extract checkpoint parts from world/core.rs to satisfy production line guard (#5358) #5365 · task 9340 · task 9341